Fix collapsed dock wrapping#45
Merged
Merged
Conversation
bjufre
force-pushed
the
fix/collapsed-dock-truncation
branch
from
7c6a9ed to
000f36b
Compare
Owner
|
ah shit, sorry about that, let me test this |
aliou
approved these changes
May 20, 2026
Owner
There was a problem hiding this comment.
Looks good. This fixes the regression from collapsed dock rows filling the terminal width after the panel helper restore.\n\nChecked diff and ran:\n- pnpm test\n- pnpm typecheck\n- pnpm lint\n\nThe one-column reserve is scoped to collapsed dock rows and tests cover long unbroken URLs, ANSI-styled content, and narrow widths.
gpt 5.5 comment 💀
Owner
|
@bjufre Thanks for the fix! releasing in a few minutes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long single-line process output can make the collapsed log dock hit the terminal right edge. In the screenshot, the dock row containing the CI URL is the
pi-processes-owned part of the layout.Before screenshot:
Scope note
The repeated loading/thinking rows above the dock are rendered by Pi core, not
pi-processes. This PR does not claim to fix that part directly. It only removes right-edge pressure from the collapsed dock so the dock is not the source of terminal wrapping/overpaint at the bottom of the layout. If the loading rows still duplicate/misplace without dock wrapping, that likely needs a separate Pi TUI/core fix.Cause
The collapsed dock padded rows to the full terminal width. That is risky at the terminal right edge when logs contain very long unbroken strings such as CI URLs.
Fix
renderCollapsedDockLine.Verification
v0.9.1; no released fix present.pnpm vitest run src/components/log-dock-component.test.tspnpm testpnpm typecheckpnpm lint